I don't like being on ships in general: too much ondulations, bad smell and disease everywhere...
If I have to, I'd choose being a pirate: more booty in general(since you can attack even ships of nations not listed on the letter of marque), plus the booty of female pirates
(it's better to have them close, or you mighr risk waking up with a cutlass in your back)
Realistically the life of the pirate was not that great:
A small chance of getting rich for a very low life expentancy(death in battle, death penalty for your crimes, stds, starving to death on a desert island, drowning, sharks food, infections...)